ext/phar: continue process of using zend_string* for alias arguments#21932
Open
Girgias wants to merge 4 commits intophp:masterfrom
Open
ext/phar: continue process of using zend_string* for alias arguments#21932Girgias wants to merge 4 commits intophp:masterfrom
Girgias wants to merge 4 commits intophp:masterfrom
Conversation
Girgias
force-pushed
the
2026-04-phar-open-or-create-filename-zstr
branch
from
5273abe to
251a774
Compare
devnexen
reviewed
May 3, 2026
|
|
||
| if (alias_len && alias) { | ||
| if (NULL == zend_hash_str_add_ptr(&(PHAR_G(phar_alias_map)), alias, alias_len, mydata)) { | ||
| if (alias) { |
Member
There was a problem hiding this comment.
note there is subtle change of behaviour throughout. i.e. empty values are potentially accepted ?
Member
Author
There was a problem hiding this comment.
I don't think we should even be accepting empty aliases in the first place.
As we want to use it to lookup hash tables and in the future copy it.
Required removing some const qualifiers on zend_string* and propagate the change to simplify the code.
Girgias
force-pushed
the
2026-04-phar-open-or-create-filename-zstr
branch
from
251a774 to
ba1f156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed in order.